-
Couldn't load subscription status.
- Fork 4.9k
docs: fix Helm chart V2 GCS storage configuration #68638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
3
commits into
master
Choose a base branch
from
devin/1761332716-fix-helm-v2-gcs-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−24
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
09ebba0
docs: fix Helm chart V2 GCS storage configuration
devin-ai-integration[bot] 0cb42a1
docs: use 3-tab interface for storage configuration and fix V1 GCS
devin-ai-integration[bot] 3e63021
docs: add secretName back for S3 and Azure storage types
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,7 +136,7 @@ Ensure you've already created a Kubernetes secret containing the credentials blo | |
| global: | ||
| storage: | ||
| type: "GCS" | ||
| secretName: airbyte-config-secrets | ||
| storageSecretName: airbyte-config-secrets # Use storageSecretName (not secretName) for GCS external secrets | ||
| bucket: # GCS bucket names that you've created. We recommend storing the following all in one bucket. | ||
| log: airbyte-bucket | ||
| state: airbyte-bucket | ||
|
|
@@ -153,7 +153,7 @@ global: | |
| global: | ||
| storage: | ||
| type: "GCS" | ||
| secretName: airbyte-config-secrets | ||
| storageSecretName: airbyte-config-secrets # Use storageSecretName (not secretName) for GCS external secrets | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume this should also be applied to the helm chart V1 sample to resolve #48842 |
||
| bucket: # GCS bucket names that you've created. We recommend storing the following all in one bucket. | ||
| log: airbyte-bucket | ||
| state: airbyte-bucket | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not used for anything anymore in s3/azure? I'm thinking at this point these docs are too confusing. It might be better to create a 3-tab interface with AWS, GCS, and Azure configurations defined separately. It seems like they're different enough that this is warranted. You should apply the same treatment to the enterprise migration guide for chart V2 too.