-
Couldn't load subscription status.
- Fork 4.9k
Source Jira: Add type definition for issue_properties value field #68634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 21f7f88. |
|
|
@airbytehq/dev-integrate based on the API docs, the value for |
| readOnly: true | ||
| value: | ||
| description: The value of the property. Required on create and update. | ||
| type: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pnilan didn't we had an outage on source-hubspot because we had a field with multiple types? Did we have a path forward for solving this problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deployed a dev image 4.3.6-dev.66c1dcca2c and tested it, seems to work. Snowflake sees the column as VARIANT and all different properties synced successfully:
But there may be something else I'm not thinking of, so I'll let you discuss and decide!
What
Adds type definition for the
valuefield in theissue_propertiesstream schema.Problem: The
valuefield inissue_propertiesstream has no type definition, causing Airbyte to infer it asUNKNOWNtype. When syncing to Snowflake destination v4.0+, this results in errors like:UNKNOWNtypes toOBJECTvaluefield can be strings, numbers, booleans, objects, or arrays (per Jira API spec:value: any)How
Added explicit type definition to the value field in the
issue_propertiesstream schema within manifest.yaml:An alternative, more conservative approach would be to use only ["null", "string"] to force all values to be stringified, which guarantees no casting errors but loses native type information. The integration team should validate that union types work correctly with Snowflake destination v4.x.
Review guide
manifest.yaml- Review theissue_propertiesstream schema definition, specifically the value field type additionUser Impact
Can this PR be safely reverted and rolled back?