Skip to content

Conversation

@maxi297
Copy link
Contributor

@maxi297 maxi297 commented Oct 24, 2025

What

Follow up to https://github.com/airbytehq/airbyte-python-cdk/releases/tag/v7.4.1

How

Up CDK version

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

@github-actions
Copy link
Contributor

πŸ‘‹ Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

πŸ“ Edit this welcome message.

@maxi297 maxi297 requested a review from tolik0 October 24, 2025 16:03
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

docs/integrations/sources/facebook-marketing.md|545 col 102| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/sources/facebook-marketing.md|547 col 102| [Vale.Spelling] Did you really mean 'logics'?
docs/integrations/sources/facebook-marketing.md|548 col 159| [Vale.Spelling] Did you really mean 'action_breakdowns'?
docs/integrations/sources/facebook-marketing.md|549 col 106| [Vale.Spelling] Did you really mean 'facebook_business'?
docs/integrations/sources/facebook-marketing.md|554 col 92| [Google.WordList] Use 'URL' instead of 'url'.
docs/integrations/sources/facebook-marketing.md|556 col 155| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/sources/facebook-marketing.md|557 col 106| [Vale.Spelling] Did you really mean 'facebook_business'?
docs/integrations/sources/facebook-marketing.md|562 col 115| [Vale.Spelling] Did you really mean 'lookback'?
docs/integrations/sources/facebook-marketing.md|564 col 114| [Vale.Spelling] Did you really mean 'async'?
docs/integrations/sources/facebook-marketing.md|568 col 120| [Vale.Spelling] Did you really mean 'params'?
docs/integrations/sources/facebook-marketing.md|569 col 116| [Vale.Spelling] Did you really mean 'async'?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Deploy preview for airbyte-docs ready!

βœ… Preview
https://airbyte-docs-ag1k4aygc-airbyte-growth.vercel.app

Built with commit 5da81e8.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

source-facebook-marketing Connector Test Results

269 tests   265 βœ…β€ƒβ€ƒ14s ⏱️
  2 suites    4 πŸ’€
  2 files      0 ❌

Results for commit 5da81e8.

@maxi297 maxi297 merged commit e4c04c3 into master Oct 27, 2025
36 checks passed
@maxi297 maxi297 deleted the maxi297/facebook_marketing_normalization_performance_improvement branch October 27, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants