-
Couldn't load subscription status.
- Fork 4.9k
Fix(Source-Zendesk-Chat): Pagination for chats and agent_timeline streams
#68629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(Source-Zendesk-Chat): Pagination for chats and agent_timeline streams
#68629
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit dec2a5a. |
402650a to
d7ca65c
Compare
d7ca65c to
e2597eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a mock server test. I'm fine with this change. Thanks!
|
/format-fix
|

What
OC Issue: https://github.com/airbytehq/oncall/issues/9459
After the 404 issues were fixed, it was discovered that users were only getting 1k records for the
chatsstream. We fetch 1k records per page so this likely means the pagination is off.I looked at the docs, but the information there did not seem to match what the actual API was responding with.
API Response:
The cursor_value needs to be corrected to
next_pageandstop_conditionappears off too.For the stop condition, I discovered that we can use the
countsince this is the count of records for each request and the API will always respond with anext_pageeven if there are no more records.I did a sanity check of all other incremental streams and the only other one failing like this was
agent_timeline. Pagination seems to be working for all other incremental streams.How
Updated the stop_condition and count for impacted streams.
Review guide
User Impact
Can this PR be safely reverted and rolled back?