Skip to content

Conversation

@agarctfi
Copy link
Contributor

@agarctfi agarctfi commented Oct 24, 2025

What

OC Issue: https://github.com/airbytehq/oncall/issues/9459
After the 404 issues were fixed, it was discovered that users were only getting 1k records for the chats stream. We fetch 1k records per page so this likely means the pagination is off.

I looked at the docs, but the information there did not seem to match what the actual API was responding with.

API Response:

    {
        "count": 200,
        "end_time": 1761312972333455,
        "next_page": "https://d3v-airbyte.zendesk.com/api/v2/chat/incremental/agent_timeline?fields=agent_timeline%28%2A%29&limit=1000&start_time=1761312972333455"
    }

The cursor_value needs to be corrected to next_page and stop_condition appears off too.

For the stop condition, I discovered that we can use the count since this is the count of records for each request and the API will always respond with a next_pageeven if there are no more records.

I did a sanity check of all other incremental streams and the only other one failing like this was agent_timeline. Pagination seems to be working for all other incremental streams.

How

Updated the stop_condition and count for impacted streams.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • [ X] YES 💚
  • NO ❌

@github-actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

source-zendesk-chat Connector Test Results

10 tests   6 ✅  13s ⏱️
 2 suites  4 💤
 2 files    0 ❌

Results for commit dec2a5a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Deploy preview for airbyte-docs ready!

✅ Preview
https://airbyte-docs-j9gq4pdk7-airbyte-growth.vercel.app

Built with commit dec2a5a.
This pull request is being automatically deployed with vercel-action

@agarctfi
Copy link
Contributor Author

Regression looks good
Screenshot 2025-10-24 at 9 49 41 AM

@agarctfi agarctfi requested a review from a team October 24, 2025 14:51
@maxi297 maxi297 self-requested a review October 24, 2025 14:54
@maxi297 maxi297 force-pushed the agarctfi/source-zendesk-chat/fix-pagination-for-chats-and-agent_timeline-steams branch from 402650a to d7ca65c Compare October 24, 2025 15:27
@maxi297 maxi297 force-pushed the agarctfi/source-zendesk-chat/fix-pagination-for-chats-and-agent_timeline-steams branch from d7ca65c to e2597eb Compare October 24, 2025 15:27
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a mock server test. I'm fine with this change. Thanks!

@agarctfi
Copy link
Contributor Author

agarctfi commented Oct 24, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (dec2a5a)

@agarctfi agarctfi merged commit 2e39498 into master Oct 27, 2025
35 checks passed
@agarctfi agarctfi deleted the agarctfi/source-zendesk-chat/fix-pagination-for-chats-and-agent_timeline-steams branch October 27, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants