-
Couldn't load subscription status.
- Fork 4.9k
chore(source-gcs): Upgrade to Python 3.13 #68619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Update Python version constraint from ^3.10,<3.12 to >=3.10,<3.15 - Update base Docker image to Python 3.13 (python-connector-base:4.1.0) - All 29 unit tests pass with Python 3.13.1 - 3/4 integration tests pass (csv test has pre-existing configuration issue) - Document upgrade process and test results Note: This change depends on airbyte-cdk being published with Python 3.13 support. A separate PR has been created for the CDK: airbytehq/airbyte-python-cdk#814 Co-Authored-By: David Gold <32782137+dbgold17@users.noreply.github.com>
Co-Authored-By: David Gold <32782137+dbgold17@users.noreply.github.com>
Original prompt from David Gold |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
|
Update dependencies Co-Authored-By: David Gold <32782137+dbgold17@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
markdownlint
[markdownlint] reported by reviewdog 🐶
MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### Blockers"]
| ### Blockers |
|
Deploy preview for airbyte-docs ready! ✅ Preview Built with commit 0a2e258. |
|
Done! I've updated both PRs to use Changes:
This constraint will support Python 3.10-3.13 without requiring the upper bound to be 3.15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
What
Upgrades the source-gcs connector to support Python 3.13.9. This change updates the Python version constraint from
^3.10,<3.12to>=3.10,<3.15, bumps the base Docker image to Python 3.13, and validates compatibility through local testing.Link to Devin run: https://app.devin.ai/sessions/898a061106974822ab17ac4b11fd057a
Requested by: David Gold (@dbgold17)
How
^3.10,<3.12to>=3.10,<3.15in pyproject.toml to align with CDK requirementspython-connector-base:4.0.2(Python 3.12) topython-connector-base:4.1.0(Python 3.13)<3.14to<3.15)Review Guide
metadata.yaml (lines 10, 14)
docker.io/airbyte/python-connector-base:4.1.0@sha256:1d1aa21d34e851df4e8a87b391c27724c06e2597608e7161f4d167be853bd7b6pyproject.toml (lines 6, 19)
>=3.10,<3.15(aligns with CDK constraint)poetry.lock -⚠️ CRITICAL ISSUE
type = "directory", url = "../../../../airbyte-python-cdk"python_313_upgrade_steps.md
docs/integrations/sources/gcs.md (line 239)
Key Issues to Review
🚨 Merge Blocker: The poetry.lock file references a local path to airbyte-python-cdk. This PR cannot be merged until:
CI Failure: The PR failed CI because:
Test Results:
'str' object has no attribute 'delivery_type')User Impact
Positive: Enables source-gcs connector to run on Python 3.13, providing access to performance improvements and new language features.
Negative: None for end users once deployed. However, this PR introduces a temporary blocker where the connector cannot be built until the CDK is updated and published.
Can this PR be safely reverted and rolled back?
Reason: This PR updates the base Docker image to Python 3.13. Once merged and deployed, reverting would require rebuilding images with the old Python 3.12 base image. However, the change itself is low-risk as all tests pass with Python 3.13 (except one pre-existing integration test failure).
Merge Checklist
Before merging this PR:
airbyte-cdk image test)