Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc about external database setup #5611

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Update doc about external database setup #5611

merged 2 commits into from
Aug 25, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Aug 25, 2021

@tuliren tuliren requested a review from marcosmarxm August 25, 2021 05:50
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 25, 2021
@tuliren tuliren mentioned this pull request Aug 25, 2021
Closed
marcosmarxm
marcosmarxm approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks Liren

@tuliren tuliren merged commit f059a27 into master Aug 25, 2021
@tuliren tuliren deleted the liren/update-external-db-doc branch August 25, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @marcosmarxm