Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination Oracle: Fix destination check for users without dba role #5307

Merged
merged 7 commits into from
Aug 12, 2021

Conversation

DoNotPanicUA
Copy link
Contributor

What

fix #4064

How

Use ALL_USERS table instead of DBA_USERS

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 10, 2021
@DoNotPanicUA DoNotPanicUA changed the title Destination Oracle: Fix destination check for users without dba role 🐛 Destination Oracle: Fix destination check for users without dba role Aug 10, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 10, 2021
@DoNotPanicUA DoNotPanicUA requested review from cgardens, sherifnada, marcosmarxm and yaroslav-hrytsaienko and removed request for cgardens August 10, 2021 16:55
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to tell the user in the issue to use the destination connector settings configurable in the UI from here:
Screen Shot 2021-08-10 at 2 44 26 PM

@DoNotPanicUA
Copy link
Contributor Author

@marcosmarxm
I've added a table with possible cases and required permissions to the destination documentation as we discussed under the issue.
Could you please review it?

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @DoNotPanicUA thanks for this

docs/integrations/destinations/oracle.md Outdated Show resolved Hide resolved
docs/integrations/destinations/oracle.md Outdated Show resolved Hide resolved
DoNotPanicUA and others added 2 commits August 11, 2021 16:42
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Aug 11, 2021

/test connector=destination-oracle

🕑 destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1120275022
✅ destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1120275022

@jrhizor jrhizor temporarily deployed to more-secrets August 11, 2021 13:46 Inactive
@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Aug 12, 2021

/publish connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1124022198
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1124022198

@jrhizor jrhizor temporarily deployed to more-secrets August 12, 2021 13:19 Inactive
@DoNotPanicUA DoNotPanicUA merged commit 64b3930 into master Aug 12, 2021
@DoNotPanicUA DoNotPanicUA deleted the aleonets/4064-fix-oracle-check-connection branch August 12, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow oracle destination to be created without create user privilege
5 participants