🧹 delete unused singer modules #5241
Conversation
…lab, and github singer modules
sherifnada
changed the title
There was a problem hiding this comment.
Before we remove anything of those, we need to make sure the customers don't have any of listed connectors in use, kind of check of usage or something, also announce that such a change takes place, so everyone is aware of it and migrate their flow to the new native connectors.
There was a problem hiding this comment.
LGTM, with small correction)
This leftover should be also removed.
SEED:
airbyte-config/init/src/main/resources/seed/source_definitions.yaml- Mixpanel-singer block should be removed
STANDARD_SOURCE_DEFINITION:
airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/859e501d-2b67-471f-91bb-1c801414d28f.json- Mixpanel-singer seed file.
.github > workflows > test-command.yml:
.github > workflows > publish-command.yml:
https://github.com/airbytehq/airbyte/blob/822337136327a1ac80a635a40ad9022a75322e21/.github/workflows/test-command.yml#L91 this line is no longer needed, referencing to the singer-tap github.
| "site_admin": { | ||
| "type": ["null", "boolean"] | ||
| } | ||
| "type": ["null", "object"], |
There was a problem hiding this comment.
So, regards this change of source-github > schemas > shared > user.json - the file was just formated, right?
|
@bazarnov thanks for the comments! made the changes you pointed out. Good catch! |
The file was deleted in #5241.
The linked file was deleted in #5241.
🧹 🧹 🧹 🧹 🧹