airbyte-ci: load built image to local docker host for java connectors #52102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alafanechere
force-pushed
the
augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors
branch
from
2740f70 to
ba512d7
Compare
alafanechere
force-pushed
the
augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors
branch
from
ba512d7 to
939f403
Compare
alafanechere
force-pushed
the
augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors
branch
from
939f403 to
96812da
Compare
alafanechere
force-pushed
the
augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors
branch
from
96812da to
58c60ca
Compare
|
I'll merge it as I got 🟢 tests on |
|
/approve-and-merge reason="destination-s3 tests are now running correctly - unblocking move team" |
|
Merged using the approve bot. |
octavia-approvington
approved these changes
Jan 23, 2025
octavia-approvington
deleted the
augustin/01-23-airbyte-ci_load_built_image_to_local_docker_host_for_java_connectors
branch
stephane-airbyte
pushed a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
airbyte-ciconnectors pipeline, focusing on loading docker images to the local docker host for Java connectors and updating related tests and documentation. The most important changes include modifying theLoadContainerToLocalDockerHostclass and its usage across different files, as well as updating the version in thepyproject.tomlfile.Key Changes:
Improvements to loading docker images:
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/build_image/steps/__init__.py: Modified therunmethod to passper_platform_built_containerstoLoadContainerToLocalDockerHost.airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/build_image/steps/common.py: Updated theLoadContainerToLocalDockerHostclass to remove thecontainersparameter from the constructor and added it to the_runmethod. [1] [2]Updates to testing:
airbyte-ci/connectors/pipelines/tests/test_build_image/test_steps/test_common.py: Adjusted tests to reflect changes inLoadContainerToLocalDockerHostby passingbuilt_containersto therunmethod. [1] [2] [3] [4] [5]Documentation and version updates:
airbyte-ci/connectors/pipelines/README.md: Added a new entry for version 4.49.2, describing the loading of docker images to the local docker host for Java connectors.airbyte-ci/connectors/pipelines/pyproject.toml: Updated the version from 4.49.1 to 4.49.2.Additional changes:
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/consts.py: Added a new constantLOAD_IMAGE_TO_LOCAL_DOCKER_HOST.airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/test/steps/java_connectors.py: Included a new step to load the docker image to the local docker host. [1] [2]