add cloud version #5198
Merged
add cloud version #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamakase when can we merge this. I know not everything is done but maybe we can do other features and bug fixes in a separate PR? |
This was
linked to
issues
Aug 9, 2021
davinchia
reviewed
Aug 9, 2021
| const Title = styled(H5)` | ||
| padding: 25px 25px 22px; | ||
| border-bottom: 1px solid ${({ theme }) => theme.greyColor20}; | ||
| //border-bottom: 1px solid ${({ theme }) => theme.greyColor20}; |
There was a problem hiding this comment.
@jamakase should this be removed?
There was a problem hiding this comment.
Actually no, this is part of new UI where we update borders and shadows. Decided to leave it as a comment to check all places more properly.
davinchia
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds some new concepts into oss version:
Adds cloud version