Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 New source: Chargebee (prepare connector for publishing) #5067

Merged
merged 14 commits into from
Jul 30, 2021
Merged

🎉 New source: Chargebee (prepare connector for publishing) #5067

merged 14 commits into from
Jul 30, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Jul 29, 2021 •
edited
Loading

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

Pre-merge Checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

@Zirochkaa Zirochkaa self-assigned this Jul 29, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 29, 2021
@Zirochkaa
Copy link
Contributor Author

Here are tests results.

image

@Zirochkaa
Update docs
8f45a53 
Update `docs/SUMMARY.md` file.
Update `docs/integrations/README.md` file.
@Zirochkaa Zirochkaa linked an issue Jul 29, 2021 that may be closed by this pull request
New Source: Chargebee #4265
Closed
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jul 30, 2021 •
edited by github-actions bot
Loading

/test connector=source-chargebee

🕑 source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1081639254
✅ source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1081639254

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 08:59 Inactive
htrueman
htrueman approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@htrueman htrueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yevhenii-ldv
yevhenii-ldv approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@yevhenii-ldv yevhenii-ldv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 small comment

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jul 30, 2021 •
edited by github-actions bot
Loading

/test connector=source-chargebee

🕑 source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1082581385
✅ source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1082581385

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 14:39 Inactive
@Zirochkaa Zirochkaa requested review from sherifnada, ChristopheDuong, tuliren, davinchia and Phlair and removed request for ChristopheDuong July 30, 2021 14:55
sherifnada
sherifnada approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, small comments!

airbyte-integrations/connectors/source-chargebee/acceptance-test-config.yml Show resolved Hide resolved
airbyte-integrations/connectors/source-chargebee/source_chargebee/source.py Show resolved Hide resolved
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jul 30, 2021 •
edited by github-actions bot
Loading

/test connector=source-chargebee

🕑 source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1083408008
✅ source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1083408008

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 19:56 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jul 30, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-chargebee

🕑 connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1083423247
✅ connectors/source-chargebee https://github.com/airbytehq/airbyte/actions/runs/1083423247

@jrhizor jrhizor temporarily deployed to more-secrets July 30, 2021 20:04 Inactive
@Zirochkaa Zirochkaa merged commit 89ea312 into master Jul 30, 2021
@Zirochkaa Zirochkaa deleted the oleh/4265-updates-for-chargebee-source branch July 30, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevhenii-ldv yevhenii-ldv yevhenii-ldv approved these changes

@htrueman htrueman htrueman approved these changes

@sherifnada sherifnada sherifnada approved these changes

@avida avida Awaiting requested review from avida

Assignees

@Zirochkaa Zirochkaa

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Source: Chargebee
6 participants
@Zirochkaa @sherifnada @htrueman @yevhenii-ldv @jrhizor @igrankova