Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: apply pre-commit format fix from #49806 #49852

Merged
merged 18 commits into from
Dec 18, 2024
Merged

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Dec 18, 2024

What

This PR applies the auto-format rules from:

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 4:44am

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Format-fix job started... Check job output.

✅ Changes applied successfully. (c88f8a5)

@aaronsteers aaronsteers force-pushed the aj/ci/test-pre-commit-fix branch from c88f8a5 to 08a740e Compare December 18, 2024 04:19
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Format-fix job started... Check job output.

✅ Changes applied successfully. (d471a80)

@aaronsteers aaronsteers force-pushed the aj/ci/test-pre-commit-fix branch from d471a80 to f02fc11 Compare December 18, 2024 04:32
Copy link
Contributor

github-actions bot commented Dec 18, 2024

Format-fix job started... Check job output.

✅ Changes applied successfully. (0303939)

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Dec 18, 2024
@aaronsteers aaronsteers changed the title CI: pre-commit format fix CI: appy pre-commit format fix from #49806 Dec 18, 2024
@aaronsteers aaronsteers changed the title CI: appy pre-commit format fix from #49806 CI: apply pre-commit format fix from #49806 Dec 18, 2024
@natikgadzhi
Copy link
Contributor

@aaronsteers the format-fix run complaints at:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-

Should we clean this up while we're here?

@aaronsteers
Copy link
Collaborator Author

aaronsteers commented Dec 18, 2024

@natikgadzhi -

@aaronsteers the format-fix run complaints at:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-

Should we clean this up while we're here?

It's been bugging me too. Created new PRs to clean these up.

@aaronsteers aaronsteers marked this pull request as ready for review December 18, 2024 06:05
@aaronsteers aaronsteers requested a review from a team as a code owner December 18, 2024 06:05
@aaronsteers aaronsteers requested a review from a team December 18, 2024 06:05
@aaronsteers aaronsteers requested review from a team as code owners December 18, 2024 06:05
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 18, 2024 06:06
@aaronsteers
Copy link
Collaborator Author

aaronsteers commented Dec 18, 2024

@natikgadzhi, @alafanechere - Failures appear to be related to version bumps:

Extra pair of eyes to confirm would be welcome.

https://github.com/airbytehq/airbyte/actions/runs/12386439202/job/34574311960?pr=49852

    def test_validation_pass_on_same_docker_image_tag(metadata_definition):
        success, error_message = metadata_validator.validate_docker_image_tag_is_not_decremented(metadata_definition, None)
>       assert success
E       assert False

Same error and URL and for all of these failures:

image image

@aaronsteers aaronsteers merged commit 83ecbe0 into master Dec 18, 2024
86 of 367 checks passed
@aaronsteers aaronsteers deleted the aj/ci/test-pre-commit-fix branch December 18, 2024 22:05
Copy link

sentry-io bot commented Dec 24, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants