Create a test container for running Airbyte with docker-compose #4970
Conversation
| @@ -1,86 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
moved this into AirbyteTestContainer
| DockerComposeContainer dockerComposeContainer = new DockerComposeContainer(secondRun) | ||
| .withLogConsumer("server", logConsumerForServer(logsToExpect)) | ||
| .withEnv(environmentVariables); | ||
| final AirbyteTestContainer airbyteTestContainer = new AirbyteTestContainer.Builder(new File(Resources.getResource("docker-compose.yaml").toURI())) |
There was a problem hiding this comment.
prefer to run using the current compose file as opposed to a frozen.
airbyte-tests/src/main/java/io/airbyte/test/airbyte_test_container/AirbyteTestContainer.java
Outdated
Show resolved
Hide resolved
| @SuppressWarnings({"unchecked", "rawtypes"}) | ||
| public void start() throws IOException, InterruptedException { | ||
| final File cleanedDockerComposeFile = prepareDockerComposeFile(dockerComposeFile); | ||
| dockerComposeContainer = new DockerComposeContainer(cleanedDockerComposeFile).withEnv(env); |
There was a problem hiding this comment.
yeah. credit goes to @subodh1810 for figuring this out originally. i'm just putting a new coat of paint on it.
|
|
||
| @SuppressWarnings("BusyWait") | ||
| private static void waitForAirbyte() throws InterruptedException { | ||
| // todo (cgardens) - assumes port 8001 which is misleading since we can start airbyte on other |
There was a problem hiding this comment.
nit: create follow up issue.
| .setPort(8001) | ||
| .setBasePath("/api")); | ||
|
|
||
| final HealthApi healthApi = apiClient.getHealthApi(); |
There was a problem hiding this comment.
this is pretty clever haha
There was a problem hiding this comment.
thanks! we had been using timeouts and then i realized we have an endpoint that handles this exact purpose. 🤣
| private void stopRetainVolumesInternal() throws InvocationTargetException, IllegalAccessException, NoSuchMethodException, NoSuchFieldException { | ||
| final Class<? extends DockerComposeContainer> dockerComposeContainerClass = dockerComposeContainer.getClass(); | ||
| try { | ||
| final Field ambassadorContainerField = dockerComposeContainerClass.getDeclaredField("ambassadorContainer"); |
There was a problem hiding this comment.
what is the ambassadorContainerField and what is the SocatContainer?
There was a problem hiding this comment.
this is the reflection stuff that subodh figured out so that we could spin down a docker compose test container without deleting volumes. i'm just moving the code. i'd have to dig a bit deeper to remember how this works.
…iner/AirbyteTestContainer.java Co-authored-by: Davin Chia <davinchia@gmail.com>
What
MigrationAcceptanceTest.java.AcceptanceTestsHow
AirbyteTestContainerMigrationAcceptanceTest.javaso that it uses the current docker compose file on the "second" run so that there is less risk of drift (it had already started).Recommended reading order
AcceptanceTests.javaAirbyteTestContainer.javaMigrationAcceptanceTest.java