Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bigquery to source_defintions yaml #4929

Closed
wants to merge 1 commit into from

Conversation

sherifnada
Copy link
Contributor

No description provided.

@sherifnada sherifnada requested a review from heade July 23, 2021 00:18
name: BigQuery
dockerRepository: airbyte/source-bigquery
dockerImageTag: 0.1.0
documentationUrl: https://docs.airbyte.io/integrations/sources/bigquery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this pr blocked until the docs are added here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is the "correct" link once it's created but airbyte-integrations/connectors/source-bigquery/src/main/resources/spec.json points to /source/bigquery instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, @heade is working on finishing docs

@DoNotPanicUA
Copy link
Contributor

Included the change into the PR #4981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants