Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Hubspot: update user-defined custom field schema generation #4913

Merged
merged 28 commits into from
Aug 3, 2021
Merged

🎉 Source Hubspot: update user-defined custom field schema generation #4913

merged 28 commits into from
Aug 3, 2021

Conversation

gaart
Copy link
Contributor

@gaart gaart commented Jul 22, 2021

What

Change the custom fields handler to produce valid JSON schema definitions.
Fix for #4779

How

Validate incoming types, fix the ones we know, fallback for the unknown with a warning.

Recommended reading order

  1. x.python

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 22, 2021
@gaart gaart requested review from keu and vitaliizazmic July 22, 2021 14:57
@gaart gaart linked an issue Jul 22, 2021 that may be closed by this pull request
Error Syncing between Hubspot to BigQuery #4779
Closed
marcosmarxm
marcosmarxm previously requested changes Jul 22, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

airbyte-integrations/connectors/source-hubspot/source_hubspot/api.py Outdated Show resolved Hide resolved
keu
keu suggested changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments

@gaart gaart requested a review from keu July 23, 2021 14:36
sherifnada
sherifnada approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaart looks great! Could you make sure to follow the "Connector Checklist" under the "pre-merge checklist" to add the following items:

  1. 🎉 to the PR title
  2. changelog to docs

airbyte-integrations/connectors/source-hubspot/unit_tests/test_field_type_converting.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-hubspot/source_hubspot/api.py Show resolved Hide resolved
@gaart @sherifnada
Set default field type to string
ff59e12 
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
@gaart gaart changed the title Source Hubspot: update user-defined custom field schema generation 🎉 Source Hubspot: update user-defined custom field schema generation Jul 27, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 27, 2021
@gaart gaart force-pushed the gaart/4779-bug-sync-hubspot-bigquery branch from cf1f573 to 418b794 Compare July 29, 2021 21:15
@gaart
Copy link
Contributor Author

gaart commented Jul 29, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1080196322
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1080196322

@gaart
Copy link
Contributor Author

gaart commented Jul 29, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1080299852
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1080299852

@gaart
Copy link
Contributor Author

gaart commented Aug 3, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1092841981
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1092841981

@gaart
Copy link
Contributor Author

gaart commented Aug 3, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1092868278
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1092868278

@gaart
Copy link
Contributor Author

gaart commented Aug 3, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1093419312
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1093419312

@gaart
Copy link
Contributor Author

gaart commented Aug 3, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1094260293
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1094260293

@jrhizor jrhizor temporarily deployed to more-secrets August 3, 2021 14:22 Inactive
@gaart
Copy link
Contributor Author

gaart commented Aug 3, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1094274757
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1094274757

@jrhizor jrhizor temporarily deployed to more-secrets August 3, 2021 14:26 Inactive
@gaart gaart dismissed marcosmarxm’s stale review August 3, 2021 14:46

Workflow is updated

@gaart gaart merged commit 25c04db into master Aug 3, 2021
@gaart gaart deleted the gaart/4779-bug-sync-hubspot-bigquery branch August 3, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@keu keu keu approved these changes

@vitaliizazmic vitaliizazmic Awaiting requested review from vitaliizazmic

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

@avida avida Awaiting requested review from avida

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Syncing between Hubspot to BigQuery
6 participants
@gaart @avida @keu @marcosmarxm @sherifnada @jrhizor