Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalization integration tests in CI #4910

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

ChristopheDuong
Copy link
Contributor

What

GitHub CI fails to run normalization integration tests successfully because it can't find and build docker images as needed

How

Describe the solution

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Jul 22, 2021

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1056435469
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1056435469

Base automatically changed from chris/dedup-nulls-last to master July 22, 2021 14:27
@ChristopheDuong ChristopheDuong force-pushed the chris/fix-normalization-ci-tests branch from 27b8ccf to b8f7041 Compare July 22, 2021 15:28
selected_integration_test="base-normalization"
integrationTestCommand="$(_to_gradle_path "airbyte-integrations/bases/base-normalization" integrationTest)"
export SUB_BUILD="NORMALIZATION"
./gradlew --no-daemon --scan airbyteDocker
Copy link
Contributor Author

@ChristopheDuong ChristopheDuong Jul 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand why :airbyte-integrations:bases:base-normalization:airbyteDocker is not executed when calling :airbyte-integrations:bases:base-normalization:integrationTest

even though in airbyte-integrations/bases/base-normalization/build.gradle:

customIntegrationTestPython.dependsOn ':airbyte-integrations:bases:base-normalization:airbyteDocker'

integrationTest.dependsOn("customIntegrationTestPython")

So to make the tests passed in the CI, I couldn't figure out anything other than explicitly invoking it here... maybe there's a better way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I remember looking at this with you and being surprised too.

this seems 'ok' as a short term fix. we should definitely create a follow up issue and look into why this is happening when we have time (after Beta launch).

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Jul 22, 2021

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1057027634
✅ bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/1057027634

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Do you think we need to investigate further why this happened?

@ChristopheDuong ChristopheDuong merged commit 9038b5e into master Jul 27, 2021
@ChristopheDuong ChristopheDuong deleted the chris/fix-normalization-ci-tests branch July 27, 2021 08:48
@Daemonxiao Daemonxiao mentioned this pull request Aug 23, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants