-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix normalization integration tests in CI #4910
Conversation
/test connector=bases/base-normalization
|
27b8ccf
to
b8f7041
Compare
selected_integration_test="base-normalization" | ||
integrationTestCommand="$(_to_gradle_path "airbyte-integrations/bases/base-normalization" integrationTest)" | ||
export SUB_BUILD="NORMALIZATION" | ||
./gradlew --no-daemon --scan airbyteDocker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand why :airbyte-integrations:bases:base-normalization:airbyteDocker
is not executed when calling :airbyte-integrations:bases:base-normalization:integrationTest
even though in airbyte-integrations/bases/base-normalization/build.gradle
:
customIntegrationTestPython.dependsOn ':airbyte-integrations:bases:base-normalization:airbyteDocker'
integrationTest.dependsOn("customIntegrationTestPython")
So to make the tests passed in the CI, I couldn't figure out anything other than explicitly invoking it here... maybe there's a better way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I remember looking at this with you and being surprised too.
this seems 'ok' as a short term fix. we should definitely create a follow up issue and look into why this is happening when we have time (after Beta launch).
/test connector=bases/base-normalization
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Do you think we need to investigate further why this happened?
What
GitHub CI fails to run normalization integration tests successfully because it can't find and build docker images as needed
How
Describe the solution