Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bmoric/stream loader #48468

Merged
merged 53 commits into from
Nov 18, 2024
Merged

Bmoric/stream loader #48468

merged 53 commits into from
Nov 18, 2024

Conversation

benmoriceau
Copy link
Contributor

@benmoriceau benmoriceau commented Nov 12, 2024

What

This is adding the file transfer capability to the bulk CDK.

How

Add a new processFile method to the stream loader which is callled when a destinationFile message is recieved.

Review guide

  • DestinationTaskLauncher.kt
  • ProcessFileTask.kt
  • ObjectStorageStreamLoaderFactory.kt

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 9:53pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit labels Nov 12, 2024
@benmoriceau benmoriceau marked this pull request as ready for review November 15, 2024 19:22
@benmoriceau benmoriceau requested review from a team as code owners November 15, 2024 19:22
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 18, 2024
@benmoriceau benmoriceau merged commit bda07f9 into master Nov 18, 2024
38 checks passed
@benmoriceau benmoriceau deleted the bmoric/stream-loader branch November 18, 2024 22:02
tryangul pushed a commit that referenced this pull request Nov 20, 2024
tryangul pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/dev-null
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants