Source Google Ads: fix for date range too narrow exception #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +77,7 @@ def get_date_params(stream_slice: Mapping[str, Any], cursor_field: str, end_date | |||
| if start_date > pendulum.now(): | |||
| return start_date.to_date_string(), start_date.add(days=1).to_date_string() | |||
|
|
|||
| end_date = min(end_date, pendulum.parse(stream_slice.get(cursor_field)).add(months=1)) | |||
| end_date = max(end_date, pendulum.parse(stream_slice.get(cursor_field)).add(months=1)) | |||
There was a problem hiding this comment.
If we accept your changes, then we will get a lot of unnecessary duplicates.
The code now works in such a way that we read data in one month.
For example, start_date is 2021-03-18, then we will have several requests:
| start_date | end_date |
|---|---|
| 2021-03-18 | 2021-04-18 |
| 2021-04-19 | 2021-05-18 |
| 2021-05-19 | 2021-06-18 |
| 2021-06-19 | 2021-07-18 |
| 2021-07-19 | 2021-07-18 |
This is where the code breaks down
If we well use your changes, then the following situation will be:
| start_date | end_date |
|---|---|
| 2021-03-18 | 2021-07-18 |
| 2021-04-19 | 2021-07-18 |
| 2021-05-19 | 2021-07-18 |
| 2021-06-19 | 2021-07-18 |
| 2021-07-19 | 2021-08-18 |
The problem exists, but change min to max is not the correct solution.
yevhenii-ldv
suggested changes
Jul 20, 2021
|
Hi @blotouta2 |
keu
changed the title
|
@blotouta2 I think we should be good to go according to @yevhenii-ldv comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Date Range Exception
How
Add support for start and end date calculation for accessing google ads report
resolves #4806
Recommended reading order
x.javay.pythonPre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
airbyte_secretin the connector's spec./gradlew :airbyte-integrations:connectors:<name>:integrationTest./test connector=connectors/<name>command as documented here is passing.README.mddocs/SUMMARY.mdif it's a new connectordocs/integrations/<source or destination>/<name>.docs/integrations/.... See changelog exampledocs/integrations/README.mdcontains a reference to the new connector/publishcommand described hereConnector Generator checklist
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes