Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Aws-cloudtrail: Migrate to manifest-only format with components #47287

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

Source AWS-Cloudtrail: Migrate to manifest-only formats with components

How

Migrated to inline schemas
Migrated spec
Migrated to manifest only with ci

Migration report

image

@btkcodedev btkcodedev self-assigned this Oct 23, 2024
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 9:51pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Oct 23, 2024
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Oct 23, 2024

/bump-version type="minor" changelog="Migrate to manifest only format"

Bump Version job started... Check job output.

✅ Changes applied successfully. (af8563b)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 23, 2024
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Oct 23, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (94523cc)

@btkcodedev
Copy link
Collaborator Author

All checks passing other than spec error

Copy link
Contributor

@ChristoGrab ChristoGrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't have usable sandbox creds, but I was able to test locally using my own AWS account. I don't have any seed data, but the auth flow succeeded; since the custom component in question is the authenticator, I'm gonna say "good enough for me". Thanks @btkcodedev!

@ChristoGrab ChristoGrab merged commit d6e50b7 into master Oct 29, 2024
39 of 40 checks passed
@ChristoGrab ChristoGrab deleted the btkcodedev/awsCloudTrialMigrate branch October 29, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/aws-cloudtrail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants