Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Load CDK: Cleanup: Files/Objects no longer Batches #46960

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

johnny-schmidt
Copy link
Contributor

What

Pretty simple

  • removed StagedLocalFile batch (unused)
  • demoted Spilled... to a data class provided by the task, got rid of its batch envelope
  • got rid of SPILLED as a state

All changes nonfunctional.

@johnny-schmidt johnny-schmidt requested a review from a team as a code owner October 16, 2024 22:05
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:35am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Oct 16, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 17, 2024 15:31
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/issue-9969-file-formats branch 3 times, most recently from 1c52f62 to 4ce86eb Compare October 17, 2024 18:06
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/issue-9969/batch-cleanup branch from 767ddbd to 088dd98 Compare October 17, 2024 18:10
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/issue-9969-file-formats branch 2 times, most recently from 7f281de to 909713d Compare October 18, 2024 00:14
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/issue-9969/batch-cleanup branch from 088dd98 to 7250f30 Compare October 18, 2024 00:16
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/issue-9969/batch-cleanup branch from 7250f30 to befb11b Compare October 18, 2024 00:17
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Oct 18, 2024
Base automatically changed from jschmidt/s3v2/issue-9969-file-formats to master October 18, 2024 00:32
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/issue-9969/batch-cleanup branch from befb11b to 83da644 Compare October 18, 2024 00:35
@johnny-schmidt johnny-schmidt enabled auto-merge (squash) October 18, 2024 00:36
@johnny-schmidt johnny-schmidt merged commit 7b12647 into master Oct 18, 2024
28 checks passed
@johnny-schmidt johnny-schmidt deleted the jschmidt/s3v2/issue-9969/batch-cleanup branch October 18, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants