-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DuckDB connector for destinations V2 #46904
base: master
Are you sure you want to change the base?
Conversation
|
@guenp is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
What
Enable Destinations V2 support for the DuckDB connector
How
_get_sql_column_definitions
method toDestinationDuckDb
based on pyairbyte'sSqlProcessorBase._get_sql_column_definitions
Review guide
Copied SqlProcessor and related files into
/sql
directory:(Update 10/21/24: we moved all changes from destination-duckdb to destination-motherduck)
Update destination to use SqlProcessor to support Destinations V2/Typing and deduping
15. airbyte-integrations/connectors/destination-motherduck/destination_motherduck/destination.py
(just a mypy typing update)
17. airbyte-integrations/connectors/destination-motherduck/destination_motherduck/run.py
Updated dependencies:
18. airbyte-integrations/connectors/destination-motherduck/poetry.lock
19. airbyte-integrations/connectors/destination-motherduck/pyproject.toml
Moved tests to
/tests
folder:20. airbyte-integrations/connectors/destination-motherduck/tests/integration_tests/config.json
21. airbyte-integrations/connectors/destination-motherduck/tests/integration_tests/configured_catalog.json
22. airbyte-integrations/connectors/destination-motherduck/tests/integration_tests/invalid_config.json
23. airbyte-integrations/connectors/destination-motherduck/tests/integration_tests/messages.jsonl
24. airbyte-integrations/connectors/destination-motherduck/tests/integration_tests/spec.json
25. airbyte-integrations/connectors/destination-motherduck/tests/unit_tests/destination_unit_tests.py
26. airbyte-integrations/connectors/destination-motherduck/tests/unit_tests/unit_test.py
Added test for duplicate message w/ upsert strategy
27. airbyte-integrations/connectors/destination-motherduck/tests/integration_tests/integration_test.py
User Impact
Airbyte will no longer create tables with column names
_airbyte_ab_id, _airbyte_emitted_at, _airbyte_data
, but instead_airbyte_raw_id, _airbyte_extracted_at, _airbyte_meta
plus any columns defined in the JSON schema.Can this PR be safely reverted and rolled back?