Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Pin CDK refs for sources with unpinned refs #46326

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Oct 3, 2024

What

CDK v5 broke these connectors and they are now failing in our nightly tests.

How

Pinning to pre-v5 refs.

Review guide

We're good to merge if CI passes.

User Impact

None expected

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 1:13pm

@natikgadzhi
Copy link
Contributor

natikgadzhi commented Oct 5, 2024

/bump-version type=patch changelog="Pin to CDK v4"

Bump Version job started... Check job output.

✅ Changes applied successfully. (368b4e5)

@natikgadzhi
Copy link
Contributor

@aaronsteers bruh ;)

process "poetry check" did not complete successfully: exit code: 1
Stdout:

Stderr:
Error: poetry.lock is not consistent with pyproject.toml. Run `poetry lock [--no-update]` to fix it.

I tried! I even bumped all your versions! poetry lock please ;)

@natikgadzhi natikgadzhi enabled auto-merge (squash) October 5, 2024 04:23
@aaronsteers aaronsteers marked this pull request as draft October 7, 2024 23:59
auto-merge was automatically disabled October 7, 2024 23:59

Pull request was converted to draft

@aaronsteers
Copy link
Collaborator Author

aaronsteers commented Oct 8, 2024

@natikgadzhi - Thanks for taking a look! I'm downgrading to 'draft' because poetry update needs to run. I tried this from a codespace but ran into an issue with gpg signature not working - had to abandon that codespace. Will pick this up after my oncall shift.

@natikgadzhi
Copy link
Contributor

I mean, I'm happy to do poetry locks for these, it's virtually five minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants