-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Pin CDK refs for sources with unpinned refs #46326
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
/bump-version type=patch changelog="Pin to CDK v4"
|
@aaronsteers bruh ;)
I tried! I even bumped all your versions! poetry lock please ;) |
@natikgadzhi - Thanks for taking a look! I'm downgrading to 'draft' because poetry update needs to run. I tried this from a codespace but ran into an issue with gpg signature not working - had to abandon that codespace. Will pick this up after my oncall shift. |
I mean, I'm happy to do poetry locks for these, it's virtually five minutes. |
What
CDK v5 broke these connectors and they are now failing in our nightly tests.
How
Pinning to pre-v5 refs.
Review guide
We're good to merge if CI passes.
User Impact
None expected
Can this PR be safely reverted and rolled back?