Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable unit tests (up to source-c...) #46301

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore: enable unit tests (up to source-c...) #46301

wants to merge 3 commits into from
+9 −5

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Oct 1, 2024 •
edited
Loading

What

A brute-force audit of skipped unitTests. Currently covers all destinations and all sources up to the letter "c".

Action plan:

  • For any connectors which can pass unit tests, we'll keep enabled and merge without bumping the connector.
  • For any connectors which cannot pass unit tests, we'll merge with a note why they are disabled.

Other notes:

  • Some of these had unitTests just not declared.
  • Some had comments that unitTests were disabled to get around test coverage failures.
  • Some had the entire test suite declaration commented out, with explicit note that acceptance tests were failing - but no comment about whether unit tests were working or expected to fail.

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 2:42pm

@aaronsteers aaronsteers mentioned this pull request Oct 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/pgvector connectors/destination/s3-glue connectors/destination/snowflake-cortex connectors/destination/vectara connectors/destination/yellowbrick connectors/source/activecampaign connectors/source/aha connectors/source/aircall connectors/source/apify-dataset connectors/source/appfollow connectors/source/auth0 connectors/source/bigcommerce connectors/source/braintree connectors/source/breezometer connectors/source/callrail connectors/source/chargify connectors/source/chartmogul connectors/source/clickhouse connectors/source/clickhouse-strict-encrypt connectors/source/clickup-api connectors/source/clockify connectors/source/coda connectors/source/coin-api connectors/source/coingecko-coins connectors/source/coinmarketcap connectors/source/commercetools connectors/source/configcat connectors/source/confluence connectors/source/convertkit connectors/source/copper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronsteers @octavia-squidington-iii