Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-postgres/mysql/mssql/mongodb-v2] Use latest CDK to adopt latest apache sshd mina to handle tcpkeepalive requests #45639

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

theyueli
Copy link
Contributor

@theyueli theyueli commented Sep 18, 2024

What

Following up on this PR: #45638
Fixes https://github.com/airbytehq/airbyte-internal-issues/issues/7

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • [ X] YES 💚
  • NO ❌

@theyueli theyueli self-assigned this Sep 18, 2024
@theyueli theyueli requested a review from a team as a code owner September 18, 2024 01:24
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 10:55am

@theyueli theyueli enabled auto-merge (squash) September 18, 2024 02:04
@theyueli theyueli requested a review from a team as a code owner September 18, 2024 10:20
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Sep 18, 2024
| 0.0.1 | 2023-08-08 | [\#28687](https://github.com/airbytehq/airbyte/pull/28687) | Initial release for testing. |
| 0.44.20 | 2024-08-30 | [\#44933](https://github.com/airbytehq/airbyte/pull/44933) | Avro/Parquet destinations: handle `{}` schemas inside objects/arrays |
| 0.44.19 | 2024-08-20 | [\#44476](https://github.com/airbytehq/airbyte/pull/44476) | Increase Jackson message length limit to 100mb |
| 0.44.18 | 2024-08-22 | [\#44759](https://github.com/airbytehq/airbyte/pull/44759) | Improve handling of incoming debezium change events |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodireich FYI, this link was wrong..

@@ -51,12 +51,12 @@ public boolean isHeartbeatSupported() {
public boolean reachedTargetPosition(final ChangeEventWithMetadata changeEventWithMetadata) {
if (changeEventWithMetadata.isSnapshotEvent()) {
return false;
} else if (SnapshotMetadata.LAST == changeEventWithMetadata.snapshotMetadata()) {
} else if (SnapshotMetadata.LAST == changeEventWithMetadata.getSnapshotMetadata()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodireich i had to apply these changes for every db sources except for mssql to make them compile again...

@theyueli theyueli merged commit 2e62443 into master Sep 18, 2024
42 checks passed
@theyueli theyueli deleted the yue/use-new-cdk branch September 18, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants