Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(source-google-search-console): fix request body for report streams by keyword #45196

Merged
merged 9 commits into from
Sep 16, 2024
Merged

fix(source-google-search-console): fix request body for report streams by keyword #45196

merged 9 commits into from
Sep 16, 2024

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Sep 6, 2024 •
edited
Loading

What

oc: https://github.com/airbytehq/oncall/issues/6297

How

comment https://github.com/airbytehq/oncall/issues/6297#issuecomment-2329129206
request records per each keyword separately

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@darynaishchenko darynaishchenko self-assigned this Sep 6, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 11:52am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-search-console labels Sep 6, 2024
@darynaishchenko
Copy link
Collaborator Author

regression tests job: link

Record count differences:

Stream search_analytics_keyword_page_report has more records in the target version .
Stream search_analytics_keyword_site_report_by_page has more records in the target version 
Stream search_analytics_keyword_site_report_by_site has more records in the target version

Keywords streams had more records in target version due to fixed missing records. Tested locally: saved connection state for search_type: web is "web": {"date": "2023-10-20"} on control version date for web wasn't update, but for target version updated state is "web" : {"date" : "2024-09-07"}. So data between these dates was lost.

@darynaishchenko darynaishchenko requested a review from a team September 9, 2024 15:50
aldogonzalez8
aldogonzalez8 reviewed Sep 9, 2024
View reviewed changes
docs/integrations/sources/google-search-console.md
@@ -226,61 +226,62 @@ Google Search Console only retains data for websites from the last 16 months. An
<summary>Expand to review</summary>

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :----------------------------------------------------------------------------------------------------------------------------- |
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I prefer to use VIM for these changes as IDE likes to mess with this file.

pnilan
pnilan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@pnilan pnilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

aldogonzalez8
aldogonzalez8 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@aldogonzalez8
Copy link
Contributor

regression tests job: link

Record count differences:

Stream search_analytics_keyword_page_report has more records in the target version .
Stream search_analytics_keyword_site_report_by_page has more records in the target version 
Stream search_analytics_keyword_site_report_by_site has more records in the target version

Keywords streams had more records in target version due to fixed missing records. Tested locally: saved connection state for search_type: web is "web": {"date": "2023-10-20"} on control version date for web wasn't update, but for target version updated state is "web" : {"date" : "2024-09-07"}. So data between these dates was lost.

/approve-regression-tests

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Sep 16, 2024 •
edited by github-actions bot
Loading

/approve-regression-tests

Check job output.

✅ Approving regression tests

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Sep 16, 2024 •
edited by github-actions bot
Loading

/approve-regression-tests

Check job output.

✅ Approving regression tests

@darynaishchenko darynaishchenko merged commit f6fd017 into master Sep 16, 2024
34 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-google-search-console/missing-fields branch September 16, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnilan pnilan pnilan approved these changes

@aldogonzalez8 aldogonzalez8 aldogonzalez8 approved these changes

Assignees

@darynaishchenko darynaishchenko

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-search-console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darynaishchenko @aldogonzalez8 @pnilan @octavia-squidington-iii