feat(source-getlago): ignore 405 response for customer usage #45193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetLago return a http 405 status code if the customer doesn't have any usage see https://github.com/getlago/lago-api/blob/1cc20119783ba9ffcec99071cb0fa4ff3d1752d2/spec/services/invoices/customer_usage_service_spec.rb#L282
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
sviande
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
sviande
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
marcosmarxm
changed the title
sviande
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
sviande
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
octavia-squidington-iii
added
the
area/documentation
marcosmarxm
had a problem deploying
to
community-ci
GitHub Actions
Error
marcosmarxm
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
marcosmarxm
had a problem deploying
to
community-ci
GitHub Actions
Error
marcosmarxm
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
marcosmarxm
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
GetLago return a http 405 status code if the customer doesn't have any active subscription see https://github.com/getlago/lago-api/blob/1cc20119783ba9ffcec99071cb0fa4ff3d1752d2/spec/services/invoices/customer_usage_service_spec.rb#L282
How
Ignore the 405 status with the code no_active_subscription
Review guide
Import a customer who has no recorded usage.
User Impact
Prevent error when a customer has no active subscription
Can this PR be safely reverted and rolled back?