🐛 Source Shopify: Have message and description be nullable for custom_collections delet… #45116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
maxi297
changed the title
octavia-squidington-iii
added
the
area/documentation
brianjlai
approved these changes
Sep 3, 2024
|
/approve-regression-tests test_record_schema_match_without_stateI'm not sure I get this test result as in both version when I run locally, I have fields like test_all_records_are_the_same_without_stateChecking the regression tests, articles, blogs, custom_collections, pages and price_rules are expected to change because they have deleted events. However, products was not supposed to change but it seems to be related to a preview URL that changed so I'm fine with this as the format of those fields are similar (there are also similar errors in other PR here).
|
maxi297
deleted the
oncall-6400/shopify-allow-message-and-description-to-be-nullable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed events
What
Addresses https://github.com/airbytehq/oncall/issues/6400 where some events have been seen to not have all the fields we expect.
Note that we haven't seen a case where
descriptionis not provided but as the field is deprecated, it makes sense to assume it won't be provided soon.How
Assume they are nullable in the Python call by calling
.get(<field>, None)from the dict in the responseReview guide
User Impact
This should allow streams to succeed but the fields that Shopify do not send us anymore will be missing
Can this PR be safely reverted and rolled back?