Fix pagination issue while setting is_resumable properly #45101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
2 tasks
girarda
approved these changes
Sep 3, 2024
|
/approve-and-merge reason="Regression tests are failing because 5.5.2 has a pagination bug causing an infinite loop" |
|
Approve this |
octavia-approvington
approved these changes
Sep 3, 2024
octavia-approvington
deleted the
maxi297/fix-pagination-issue-while-setting-resumable-properly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Basically, even though we set the cursor as “not RFR”, the stream is considered resumable because of this as the HttpStream always defines the state property even though when calling the state method for the StripeStream we get
AttributeError: _state. As it is considered resumable but is not incremental, the checkpoint mode is RFR and we end up looping indefinitely one ignored responsesHow
Manually flagging
is_resumableon each streamsUser Impact
Streams failing because on how it was resuming should start working again.
Can this PR be safely reverted and rolled back?