feat(airbyte-cdk): use orjson to speed up parsing
#44829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip CI] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
artem1205
changed the title
orjson to speed up parsing
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
|
/approve-regression-tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve https://github.com/airbytehq/airbyte-internal-issues/issues/9428
Reason: orjson is much faster than standard json
How
replace
jsonwithorjsonfor encoders/parsersMost important/heavily used is change in
JsonlDecoderhttps://github.com/airbytehq/airbyte/pull/44589/files#diff-404f304b08b4a327259c7999f75283e1f111edaac2bb09196cb2c536f141f2deL74-L75Tip
The difference for the test
test_jsonl_decoder_memory_usageis about 20%.Review guide
User Impact
Can this PR be safely reverted and rolled back?