Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(source-google-ads): fix abnormal state for ad_group_criterion and campaign_criterion #44816

Merged

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Aug 27, 2024

What

Fix incremental test for streams ad_group_criterion and campaign_criterion.

How

Set abnormal state for ad_group_criterion and campaign_criterion to 2222 instead of 2022.

User Impact

No user impact.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Aug 27, 2024
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 2:27pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 27, 2024
@tolik0 tolik0 marked this pull request as ready for review August 27, 2024 14:13
This reverts commit dac2d60.
@tolik0 tolik0 self-assigned this Aug 27, 2024
@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Aug 27, 2024
@tolik0 tolik0 requested a review from a team August 27, 2024 14:22
@tolik0
Copy link
Contributor Author

tolik0 commented Aug 28, 2024

/approve-regression-tests

Check job output.

✅ Approving regression tests

@tolik0 tolik0 merged commit bcfe72b into master Aug 28, 2024
37 checks passed
@tolik0 tolik0 deleted the tolik0/source-google-ads/fix-abnormal-state-ad-group-criterion branch August 28, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants