Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-zendesk-support): add automations and triggers streams #44610

Merged

Conversation

henriblancke
Copy link
Contributor

What

Add missing streams:

  • Automations
  • Triggers

User Impact

Users will be able to now sync automations and triggers

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 10, 2024 0:59am

Signed-off-by: Henri Blancke <blanckehenri@gmail.com>
@marcosmarxm
Copy link
Member

Running CI Tests @henriblancke !

@marcosmarxm marcosmarxm changed the title πŸ› Source Zendesk Support: add automations and triggers streams feat(source-zendesk-support): add automations and triggers streams Sep 8, 2024
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @henriblancke need final approval from connector team.

Comment on lines +74 to +75
{"stream":"automations","data":{"url":"https://d3v-airbyte.zendesk.com/api/v2/automations/6241378811151.json","id":6241378811151,"title":"Close ticket 4 days after status is set to solved","active":true,"updated_at":"2023-01-19T00:26:48Z","created_at":"2023-01-19T00:26:48Z","default":true,"actions":[{"field":"status","value":"closed"}],"conditions":{"all":[{"field":"status","operator":"is","value":"solved"},{"field":"SOLVED","operator":"greater_than","value":"480"}],"any":[]},"position":0,"raw_title":"Close ticket 4 days after status is set to solved"},"emitted_at":1725816608179}
{"stream":"triggers","data":{"url":"https://d3v-airbyte.zendesk.com/api/v2/triggers/7282769224079.json","id":7282769224079,"title":"Request customer satisfaction rating (social messaging)","active":true,"updated_at":"2023-06-26T10:48:19Z","created_at":"2023-06-26T10:48:19Z","default":false,"actions":[{"field":"notification_messaging_csat","value":"requester_id"}],"conditions":{"all":[{"field":"status","operator":"value","value":"solved"}],"any":[{"field":"via_id","operator":"is","value":"73"},{"field":"via_id","operator":"is","value":"72"},{"field":"via_id","operator":"is","value":"74"},{"field":"via_id","operator":"is","value":"78"},{"field":"via_id","operator":"is","value":"88"}]},"description":"Asks customer for a rating after the conversation is over. This trigger is created by the system.","position":8,"raw_title":"Request customer satisfaction rating (social messaging)","category_id":"1276235"},"emitted_at":1725816657977}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for adding the expected records.

Copy link
Contributor

@aldogonzalez8 aldogonzalez8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldogonzalez8
Copy link
Contributor

Can you update the date in docs/integrations/sources/zendesk-support.md ? For the rest, it looks good to me.

@marcosmarxm marcosmarxm merged commit ba63c03 into airbytehq:master Sep 10, 2024
33 checks passed
@henriblancke henriblancke deleted the zendesk-automations-triggers branch September 11, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/zendesk-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants