Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supportsDBT and supportsNormalization to API objects #4031

Merged
merged 4 commits into from
Jun 11, 2021

Conversation

ChristopheDuong
Copy link
Contributor

@ChristopheDuong ChristopheDuong commented Jun 10, 2021

What

#3779 added fields to protocol but not exposing it to API

How

Expose them to API so #3921 can use them

@github-actions github-actions bot added area/platform issues related to the platform area/documentation Improvements or additions to documentation area/protocol CDK Connector Development Kit labels Jun 10, 2021
Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you chose a field structure instead of a list of enums?

LGTM otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/platform issues related to the platform area/protocol CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants