Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mysql-cdc: handle tinyint(1) and boolean correctly + fix target file comparison #3890

Merged
merged 8 commits into from
Jun 7, 2021
Merged

fix mysql-cdc: handle tinyint(1) and boolean correctly + fix target file comparison #3890

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca44958
fix mysql-cdc: handle tinyint(1) as boolean + fix taget file comparison
subodh1810 Jun 4, 2021
17740fc
fix formatting
subodh1810 Jun 4, 2021
f3a9b33
simplify shouldSignalClose method
subodh1810 Jun 4, 2021
9f2c986
only deserialize once
subodh1810 Jun 4, 2021
836c578
address review comments
subodh1810 Jun 7, 2021
08fec8e
upgrade version
subodh1810 Jun 7, 2021
1fe3f8a
Merge branch 'master' into mysql-cdc-tinyint-handling
subodh1810 Jun 7, 2021
4a40de6
upgrade version
subodh1810 Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
only deserialize once
  • Loading branch information
@subodh1810
subodh1810 committed Jun 4, 2021
commit 9f2c9861207f425cbc6e6c309f5275484ca994d0
8 changes: 5 additions & 3 deletions ...urce-mysql/src/main/java/io/airbyte/integrations/source/mysql/DebeziumRecordIterator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

package io.airbyte.integrations.source.mysql;

import com.fasterxml.jackson.databind.JsonNode;
import com.google.common.collect.AbstractIterator;
import io.airbyte.commons.concurrency.VoidCallable;
import io.airbyte.commons.json.Jsons;
Expand Down Expand Up @@ -115,11 +116,12 @@ private boolean shouldSignalClose(ChangeEvent<String, String> event) {
return false;
}

String file = Jsons.deserialize(event.value()).get("source").get("file").asText();
int position = Jsons.deserialize(event.value()).get("source").get("pos").asInt();
JsonNode valueAsJson = Jsons.deserialize(event.value());
String file = valueAsJson.get("source").get("file").asText();
int position = valueAsJson.get("source").get("pos").asInt();

boolean isSnapshot = SnapshotMetadata.TRUE == SnapshotMetadata.valueOf(
Jsons.deserialize(event.value()).get("source").get("snapshot").asText().toUpperCase());
valueAsJson.get("source").get("snapshot").asText().toUpperCase());

if (isSnapshot || targetFilePosition.get().fileName.compareTo(file) > 0 || targetFilePosition.get().position >= position) {
return false;
Expand Down