🐛 Source Google Sheets: emit state message #38851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
artem1205
requested changes
Jun 3, 2024
airbyte-integrations/connectors/source-google-sheets/source_google_sheets/source.py
Outdated
Show resolved
Hide resolved
Comment on lines
+210
to
+216
| yield as_airbyte_message(stream, AirbyteStreamStatus.RUNNING) | ||
| for row in row_values: | ||
| if not Helpers.is_row_empty(row) and Helpers.row_contains_relevant_data(row, column_index_to_name.keys()): | ||
| yield AirbyteMessage(type=Type.RECORD, record=Helpers.row_data_to_record_message(sheet, row, column_index_to_name)) | ||
|
|
||
| yield self._checkpoint_state(checkpoint_reader.get_checkpoint(), state_manager, sheet, None) | ||
| yield as_airbyte_message(stream, AirbyteStreamStatus.COMPLETE) |
There was a problem hiding this comment.
Please add error handling for per-stream error, like it is implemented in class AbstractSource
There was a problem hiding this comment.
does it affect emitting a state message? I'd rather implement it in a separate ticket if it does not
….com:airbytehq/airbyte into ddavydov/source-google-sheets-emit-state-msg
artem1205
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://github.com/airbytehq/airbyte-internal-issues/issues/7425
How
Emit a state message at least once per stream
User Impact
No negative impact expected
Can this PR be safely reverted and rolled back?