Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Redshift: CDK update with least changes #38825

Merged
merged 3 commits into from
May 31, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented May 31, 2024

What

Adapting to last known safe version of CDK before proceeding with rewrite of new interfaces.
This should not have any functional changes.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@gisripa gisripa requested a review from a team as a May 31, 2024 18:16
Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 8:22pm

@gisripa gisripa force-pushed the gireesh/redshift-cdk-safe-update branch from e84f601 to 6175305 Compare May 31, 2024 19:57
@octavia-squidington-iii octavia-squidington-iii removed area/documentation Improvements or additions to documentation CDK Connector Development Kit labels May 31, 2024
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this is still safe to merge, right? b/c it's not introducing any of the new classes)

@gisripa
Copy link
Contributor Author

gisripa commented May 31, 2024

(this is still safe to merge, right? b/c it's not introducing any of the new classes)

Yeah. there should be no functional changes, just one unused method.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 31, 2024
@gisripa gisripa enabled auto-merge (squash) May 31, 2024 20:19
@gisripa gisripa merged commit 82aca52 into master May 31, 2024
31 checks passed
@gisripa gisripa deleted the gireesh/redshift-cdk-safe-update branch May 31, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/redshift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants