Destination Snowflake: Kotlin convert DestinationHandler #38629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced May 23, 2024
2 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
gisripa
changed the title
gisripa
commented
May 23, 2024
| .associateTo(LinkedHashMap()) { it.key!! to it.value.type } | ||
| // soft-resetting https://github.com/airbytehq/airbyte/pull/31082 | ||
| val hasPksWithNonNullConstraint: Boolean = | ||
| existingTable.columns.any { pks.contains(it.key) && !it.value.isNullable } |
There was a problem hiding this comment.
gisripa
commented
May 23, 2024
| AND table_schema IN (${IntRange(1, streamIds.size).joinToString { "?" }}) | ||
| AND table_name IN (${IntRange(1, streamIds.size).joinToString { "?" }}) | ||
|
|
||
| """.trimIndent() |
There was a problem hiding this comment.
gisripa
force-pushed
the
gireesh/05-23-snowflake-desthandler-kotlin
branch
2 times, most recently
from
bf9c2f2
to
ddea09b
Compare
gisripa
force-pushed
the
gireesh/05-23-snowflake-minor-cleanup
branch
from
754cac2
to
40e1576
Compare
gisripa
force-pushed
the
gireesh/05-23-snowflake-desthandler-kotlin
branch
from
ddea09b
to
3d19907
Compare
2 tasks
gisripa
force-pushed
the
gireesh/05-23-snowflake-minor-cleanup
branch
from
40e1576
to
9f42ddf
Compare
gisripa
force-pushed
the
gireesh/05-23-snowflake-desthandler-kotlin
branch
from
3d19907
to
8350775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
SnowflakeDestinationHandlerconversion to Kotlin.Few blocks had to be rewritten because auto conversion produced convoluted code and compilation errors.
User Impact
Can this PR be safely reverted and rolled back?