Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-intercom): add step granularity for activity logs stream #38626

Merged
merged 3 commits into from
May 24, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented May 23, 2024

What

Resolving https://github.com/airbytehq/oncall/issues/5397

How

  • add step granularity for activity logs stream
    reason:
    500 error likely raised due to too big interval, experimentally got stable response with step == 5 days

Review guide

  1. airbyte-integrations/connectors/source-intercom/source_intercom/spec.json
  2. airbyte-integrations/connectors/source-intercom/source_intercom/manifest.yaml

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 5:41pm

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 23, 2024
@artem1205 artem1205 marked this pull request as ready for review May 23, 2024 20:06
@artem1205 artem1205 requested a review from a team May 23, 2024 20:06
@artem1205 artem1205 merged commit 4d3668d into master May 24, 2024
36 checks passed
@artem1205 artem1205 deleted the artem1205/source-intercom-OC-5397 branch May 24, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/intercom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants