airbyte-ci: do not eagerly fetch connector secrets #38615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/05-23-airbyte-ci_do_not_eagerly_fetch_connector_secrets
branch
from
8ec5f67
to
8133703
Compare
bnchrch
approved these changes
May 23, 2024
alafanechere
force-pushed
the
augustin/05-23-airbyte-ci_do_not_eagerly_fetch_connector_secrets
branch
from
8133703
to
22d6e0b
Compare
alafanechere
deleted the
augustin/05-23-airbyte-ci_do_not_eagerly_fetch_connector_secrets
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#38322 introduces an edge case bug when
airbyte-ci connectors testis run with--skip-stepor--only-step:Even if some test suites are skipped the existing logic tried to fetch the secrets from the secret stores.
It breaks community CI and other workflow which only run a portion of the full test pipeline.
Solution
Fetch secerts according to the
run_step_options.A lot of secret related logic moved to the ConnectorContext class as it's where these options are exposed.