Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash location for run-ab-platform.sh #38604

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

uskudnik
Copy link
Contributor

What

Finds the default bash of the current environment, as some systems don't have bash in /bin/bash.

How

It changes the first line that specifies the interpreter to use /usr/bin/env

Review guide

Execute run-ab-platform.sh and verify it works.

User Impact

Users of systems not havin bash in /bin/bash will be able to run run-ab-platform.sh.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Finds the default bash of the current environment, as some systems
don't have bash in /bin/bash.
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:16am

@CLAassistant
Copy link

CLAassistant commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not my domain, but seems reasonable.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks it looks your suggestion make more portable to use the script in different platforms.

@marcosmarxm marcosmarxm merged commit 85238eb into airbytehq:master Jun 3, 2024
30 checks passed
@uskudnik uskudnik deleted the fix-bash-location branch June 6, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants