Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Open Weather: Make Connector Compatible with Builder #38601

Merged
merged 4 commits into from
May 23, 2024
Merged

✨Source Open Weather: Make Connector Compatible with Builder #38601

merged 4 commits into from
May 23, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this May 23, 2024
@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 7:04pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 23, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 23, 2024 08:08
@btkcodedev btkcodedev requested a review from girarda May 23, 2024 08:21
@btkcodedev
Copy link
Collaborator Author

CI green ✅
Removed Parameters macro ✅

Ready to merge ✅

image

@natikgadzhi natikgadzhi enabled auto-merge (squash) May 23, 2024 19:00
@natikgadzhi natikgadzhi merged commit 97ceaed into master May 23, 2024
32 checks passed
@natikgadzhi natikgadzhi deleted the btkcodedev/openweatherCompatible branch May 23, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi approved these changes

@girarda girarda Awaiting requested review from girarda

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/openweather
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btkcodedev @natikgadzhi @octavia-squidington-iii