Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Shopify: migrate Order Risks to GraphQL BULK #38352

Merged

Conversation

bazarnov
Copy link
Collaborator

What

Resolving:

How

  • added new OrderRisk graphql query type
  • pinned the shopify API version to 2024-04 for that stream specifically, because older versions don't cover the deprication changes listed here, the latest version should be used instead.
  • covered with the unit test case

User Impact

No impact is expected

Can this PR be safely reverted and rolled back?

  • YES 💚

@bazarnov bazarnov self-assigned this May 20, 2024
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 9:09am

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 20, 2024
@bazarnov bazarnov marked this pull request as ready for review May 20, 2024 15:30
@bazarnov bazarnov requested a review from a team May 20, 2024 15:30
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested manually but it seems pretty sweet. Just one comment

Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we document what happens when the schema is not refreshed and that there is no customer impact, I'm fine with this change

@bazarnov bazarnov merged commit fa43741 into master May 23, 2024
30 checks passed
@bazarnov bazarnov deleted the baz/source/shopify/migrate-order-risks-to-grapghql-bulk branch May 23, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/shopify team/critical-connectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants