Bug: Fix issue with Pinecone custom namespaces not being created automatically #38336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
bindipankhudi
commented
May 18, 2024
| @@ -137,7 +137,9 @@ def index(self, document_chunks, namespace, streamName): | |||
| for batch in serial_batches: | |||
| async_results = [] | |||
| for ids_vectors_chunk in create_chunks(batch, batch_size=PINECONE_BATCH_SIZE): | |||
| async_result = self.pinecone_index.upsert(vectors=ids_vectors_chunk, async_req=True, show_progress=False) | |||
| async_result = self.pinecone_index.upsert( | |||
| vectors=ids_vectors_chunk, async_req=True, show_progress=False, namespace=namespace | |||
There was a problem hiding this comment.
added back namespace param which got removed during pinecone serverless implementation.
bindipankhudi
commented
May 18, 2024
| @@ -107,3 +125,44 @@ def test_write(self): | |||
| vector_store = Pinecone(self.pinecone_index_rest, embeddings.embed_query, "text") | |||
| result = vector_store.similarity_search("feline animals", 1) | |||
| assert result[0].metadata["_ab_record_id"] == "mystream_2" | |||
|
|
|||
| def test_write_with_namespace(self): | |||
There was a problem hiding this comment.
added tests which insert with namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #38335
and https://github.com/airbytehq/oncall/issues/5319