-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(docs): Update metadata callout style #38296
update(docs): Update metadata callout style #38296
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ac1d582
to
2c4c3c9
Compare
44c0a37
to
e3ec635
Compare
2c4c3c9
to
0235267
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some questions and suggestions, but this is looking good overall!
line-height: 0.8rem; | ||
text-transform: uppercase; | ||
font-weight: var(--ifm-font-weight-semibold); | ||
color: #252537 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you explicitly make this not point to a color variable because you wanted it to be the same across light and dark mode?
If so, I'd recommend still setting this to a new color variable name and making it the same value across both, just to keep the consistency of having all of our color values in one file and in the same format
<MetadataStat label="Support Level"> | ||
<a href="/integrations/connector-support-levels/"> | ||
<Chip>{supportLevel}</Chip> | ||
</a> | ||
</MetadataStat> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e3ec635
to
a2a5b1a
Compare
0235267
to
0313291
Compare
@lmossman This is back up for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one final suggestion, otherwise this LGTM!
.metadataStatValue { | ||
display: inline-flex; | ||
align-items: center; | ||
margin: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
margin: 0; | |
margin: 0; | |
a { | |
display: inline-flex; | |
align-items: center; | |
} |
This should fix the vertical alignment issue I mentioned here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh shoot did that last change not fix it?
Looking again!
0313291
to
04ba3b5
Compare
04ba3b5
to
f5f4f81
Compare
What
We have a new metadata component styling
https://www.figma.com/design/JX15SrsqQK53Gm3Ekg1Dq5/Connector-Quality-Indicators?node-id=78-144&t=IGbmxVgtqAISCxTu-0
How
Blockers