Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(destination-weaviate): Replace AirbyteLogger with logging.Logger #38272

Merged
merged 4 commits into from
May 20, 2024
Merged

refactor(destination-weaviate): Replace AirbyteLogger with logging.Logger #38272

merged 4 commits into from
May 20, 2024

Conversation

girarda
Copy link
Contributor

@girarda girarda commented May 16, 2024 •
edited
Loading

What

Replace usage of deprecated AirbyteLogger with logging.Logger

Can this PR be safely reverted and rolled back?

  • YES 💚

@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 4:05am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/weaviate labels May 16, 2024
@girarda girarda changed the title Replace AirbyteLogger with logging.Logger refactor(destination-weaviate):Replace AirbyteLogger with logging.Logger May 16, 2024
@girarda girarda changed the title refactor(destination-weaviate):Replace AirbyteLogger with logging.Logger refactor(destination-weaviate): Replace AirbyteLogger with logging.Logger May 16, 2024
@girarda girarda marked this pull request as ready for review May 16, 2024 20:38
@girarda girarda requested a review from a team as a code owner May 16, 2024 20:38
bindipankhudi
bindipankhudi approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@bindipankhudi bindipankhudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thank you for updating this :)

@girarda girarda merged commit d7d5fb9 into master May 20, 2024
29 checks passed
@girarda girarda deleted the alex/destination_weaviate branch May 20, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bindipankhudi bindipankhudi bindipankhudi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/weaviate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@girarda @bindipankhudi @octavia-squidington-iii