refactor(source-shopify): Replace AirbyteLogger with logging.Logger #38251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
girarda
changed the title
girarda
commented
May 20, 2024
girarda
changed the title
Comment on lines
+253
to
254
| | 0.1.30 | 2022-01-24 | [9648](https://github.com/airbytehq/airbyte/pull/9648) | Added permission validation before sync | | ||
| | 0.1.29 | 2022-01-20 | [9049](https://github.com/airbytehq/airbyte/pull/9248) | Added `shop_url` to the record for all streams | |
There was a problem hiding this comment.
Nit: Was there any reason not to reduce the spaces before the pipe in the version column from 0.1.29 to below? And is there any reason not to do the same on the rest?
There was a problem hiding this comment.
I just used the bump command. I didn't manually edit these lines
airbyte-ci connectors --name=source-shopify bump_version patch 38251 "Replace AirbyteLogger with logging.Logger"
aldogonzalez8
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace usage of deprecated AirbyteLogger with logging.Logger
Can this PR be safely reverted and rolled back?