fix: use correct icon url path in metadata publish #38247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
2 tasks
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @erohmensing and the rest of your teammates on |
alafanechere
approved these changes
May 16, 2024
bnchrch
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix an issue where connector publishing would not upload the icon to the metadata service. In this PR, we started to make modifications to the metadata file before we upload it. This leads to us rewriting the modified file to a tempfile path. However, since we are inferring the doc url based on the metadata file path, when we update the filepath to point to the new temp file, we lose the pointer to the doc url
See context thread here
How
Get the icon URL path before modifying the metadata file.
Also log the things we don't upload as well as the things that we do, so that this doesn't take like 4 hours to track down next time 😅
Can this PR be safely reverted and rolled back?