Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mongodb to use dbz 2.6.2 #38238

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Upgrade mongodb to use dbz 2.6.2 #38238

merged 11 commits into from
Jun 11, 2024

Conversation

xiaohansong
Copy link
Contributor

@xiaohansong xiaohansong commented May 15, 2024

What

Upgrade mongodb DBZ dependency - now we are using 2.6.2

https://github.com/airbytehq/airbyte-internal-issues/issues/6366

2.6.2 deprecated replica_set reading so we have to use preferred sharded reading. That changed the content in offset file, thus we need to create a new way to write and read it.

Also existing syncs will need to go through a special state handling logic, or otherwise offset file won't be recognizable by new readers.

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@xiaohansong xiaohansong requested a review from a team as a code owner May 15, 2024 22:11
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs 🛑 Canceled (Inspect) Jun 11, 2024 5:21pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/mongodb-v2 labels May 15, 2024
return mapAsString
}

LOGGER.info { "Mutating sate to make it Debezium 2.6 compatible" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sTate

@@ -38,8 +38,8 @@ java {
}

dependencies {
implementation 'io.debezium:debezium-embedded:2.5.1.Final'
implementation 'io.debezium:debezium-connector-mongodb:2.5.1.Final'
implementation 'io.debezium:debezium-embedded:2.6.0.Final'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps using the current stable 2.6.2.Final?
I see a few fixes for mongodb

@xiaohansong xiaohansong requested a review from a team as a code owner June 11, 2024 16:52
@xiaohansong
Copy link
Contributor Author

xiaohansong commented Jun 11, 2024

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9469687576
✅ Successfully published Java CDK version=0.37.2!

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 11, 2024
@xiaohansong xiaohansong changed the title Upgrade mongodb to use dbz 2.6 Upgrade mongodb to use dbz 2.6.2 Jun 11, 2024
@xiaohansong xiaohansong enabled auto-merge (squash) June 11, 2024 17:06
@xiaohansong xiaohansong merged commit 3c9a612 into master Jun 11, 2024
29 of 30 checks passed
@xiaohansong xiaohansong deleted the xiaohan/mongodb-dbz-26 branch June 11, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/mongodb-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants