Add namespaceDefinitionType to standardSync #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheDuong
force-pushed
the
chris/namespace-change
branch
from
ed5bb6c to
13b34e0
Compare
ChristopheDuong
changed the title
2 tasks
davinchia
reviewed
Jun 3, 2021
|
|
||
| // This migration does the following: | ||
| // 1. Add fields to StandardSync. | ||
| public class MigrationV0_25_0 extends BaseMigration implements Migration { |
There was a problem hiding this comment.
you preempted my migration question!
davinchia
reviewed
Jun 3, 2021
| @@ -2096,6 +2102,13 @@ components: | |||
| - days | |||
| - weeks | |||
| - months | |||
| NamespaceDefinitionType: | |||
There was a problem hiding this comment.
discussed offline: we should leave a comment here explaining the default behaviour
davinchia
reviewed
Jun 3, 2021
| return catalog; | ||
| } | ||
|
|
||
| @Override | ||
| public AirbyteMessage mapMessage(final AirbyteMessage inputMessage) { | ||
| if (inputMessage.getType() == Type.RECORD) { | ||
| final AirbyteMessage message = Jsons.clone(inputMessage); | ||
| if (namespaceDefinition != null && namespaceDefinition.equals(NamespaceDefinitionType.DESTINATION)) { |
There was a problem hiding this comment.
spoke offline: same comment here about default behaviour possibly linking to the api spec file.
davinchia
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements backend part of #3481
How
Expose an option on how to use the source namespaces in the destination:
Pre-merge Checklist
Recommended reading order
airbyte-workers/src/main/java/io/airbyte/workers/protocols/airbyte/NamespacingMapper.javaairbyte-api/src/main/openapi/config.yamlsee https://docs.google.com/document/d/1qFk4YqnwxE4MCGeJ9M2scGOYej6JnDy9A0zbICP_zjI/edit# for more context