bug(registry): fix auto materialize #38094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
/approve-and-merge reason="hotfix registry orchestrator" |
|
Lets merge it |
octavia-approvington
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR fixes an issue where automaterialize is currently not running by updating registry_entry it to pull Airbyte Slack users from the graph, instead of taking it as an argument.
What changed?
The
metadata_entryandregistry_entryfunctions inregistry_entry.pyno longer takeairbyte_slack_usersas an argument. Instead, these functions call theget_airbyte_slack_users_from_graphfunction fromhacks.pyto get the required Slack users. This function has also been updated to handle exceptions and return 'None' if it fails to get the Slack users.Why make this change?
This was a hack recommended by the dagster team to get automaterialize working again
https://airbytehq-team.slack.com/archives/C048P9GADFW/p1715276222825929