-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Mixpanel - Add new datatime formats for state for cohort_members stream, added obsolete state reset for cohort_members stream #38066
Merged
Merged
Changes from 33 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
efc1ab0
Added new datatime formats for state for cohort_members stream, added…
midavadim 253dfea
fix unit test
midavadim 3b7ab40
format
midavadim 85db1b2
Merge branch 'master' into midavadim/mixpanel-datatime-fix
lazebnyi ba2d280
updated test coverage
midavadim 91c52b3
Merge remote-tracking branch 'origin/midavadim/mixpanel-datatime-fix'…
midavadim a60dba2
removed odd end date
midavadim e81326a
added client side filtration of old records
midavadim 7046c2c
added change history for breaking change
midavadim d0d061e
added filtering based on start_date
midavadim a36f99c
Merge branch 'master' into midavadim/mixpanel-datatime-fix
midavadim 2e07f3c
format
midavadim 0947701
format
midavadim 82d3717
added filter based on start_date fixed unit test
midavadim ef816af
update abnormal state
midavadim 0cda51b
update upgradeDeadline
midavadim 5caec34
Key is changed to new unique key (based on 'distinct_id' and 'cohort_…
midavadim a6a3ff2
removed odd pytz package for testing
midavadim c5f43d8
chore: auto-fix lint and format issues
octavia-squidington-iii 32925d5
reverted state migration since due to breaking change state and data …
midavadim 2b0d86c
Merge remote-tracking branch 'origin/midavadim/mixpanel-datatime-fix'…
midavadim 45b3881
set key for cohort_members
midavadim 8e5a1a1
Merge branch 'master' into midavadim/mixpanel-datatime-fix
midavadim 463ac1b
updated change log message
midavadim dd88ee7
fix unit test for cohort_members
midavadim a383794
updated deadline, removed not used import
midavadim 94194e8
format
midavadim 422278c
removed dockerImageTag
midavadim 8aafe69
updated change history messages
midavadim b966769
format
midavadim 86007c1
added unit test for states in semiincremental stream. Use stream_inte…
midavadim fa2741b
added unit test for pagination for partition stream.
midavadim 16a97a9
Merge branch 'master' into midavadim/mixpanel-datatime-fix
midavadim daa5975
Merge branch 'master' into midavadim/mixpanel-datatime-fix
midavadim 2af956b
Merge branch 'master' into midavadim/mixpanel-datatime-fix
midavadim 863d8d8
Merge remote-tracking branch 'origin/midavadim/mixpanel-datatime-fix'…
midavadim 9d825ed
disabled cache before each test
midavadim 87746bd
format
midavadim 545ed7b
Update docs/integrations/sources/mixpanel-migrations.md
lazebnyi 560f392
Updated breaking changes notes and message
lazebnyi 422ff2f
Update airbyte-integrations/connectors/source-mixpanel/metadata.yaml
midavadim 221c7ae
prettier format
midavadim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lazebnyi @midavadim don't we need to have impactscope?
-let's change this message to be more customer friendly. This information is good, but I think it belongs in the migration guide, not the breaking change warning.
-please pic a format for the stream either CohortMembers or cohort_members
-user needs to understand what action needs to be taken. General format is "x stream has changed for y reason. Please reset x stream. See migration guide for further details."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated